Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve local_development.yml file to allow users choose between HTTPS/GIT clone methods. #52

Closed
wants to merge 1 commit into from
Closed

Improve local_development.yml file to allow users choose between HTTPS/GIT clone methods. #52

wants to merge 1 commit into from

Conversation

BreakingPitt
Copy link

Description

This pull request addresses the need to enhance the local_development.yml configuration file, providing users with the option to choose their preferred clone method between HTTPS and GIT.

This improvement allows for greater customization and flexibility during the development environment setup process.

Changes

  • Added a new variable clone_method to the vars_prompt section of the playbook.
  • The clone_method variable allows users to select either HTTPS or GIT as their preferred clone method.
  • Modified the repository cloning task to use the selected clone method specified by the clone_method variable.
  • Included a default value of HTTPS for the clone_method variable to ensure seamless execution for users who do not make a selection.

Testing

Thoroughly tested the playbook with both HTTPS and GIT clone methods to verify functionality and correctness.
Ensured that the default behavior remains consistent and functional.

Related Issues:

Fixes #49

wmudge
wmudge requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the PR - just a quick request to handle the prompt.

local_development.yml Outdated
@@ -17,6 +17,11 @@
hosts: localhost
connection: local
gather_facts: yes
vars_prompt:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a bit of validation, like:

- name: Get input
  ansible.builtin.pause:
    prompt: "Enter 'https' or 'git'"
  register: input
  until: input.user_input | lower in ['https', 'git']
  retries: 3
  delay: 0

@wmudge wmudge changed the base branch from main to devel September 19, 2023 14:17
@wmudge
Copy link
Member

wmudge commented Sep 19, 2023

I also switch the target branch to devel, which resulted in a conflict in README.adoc. This particular file is about to disappear, so reconciliation as needed.

@wmudge wmudge added enhancement New feature or request good first issue Good for newcomers labels Sep 19, 2023
@wmudge wmudge added this to the Release 2.0.1 milestone Oct 26, 2023
@wmudge wmudge removed this from the Release 2.0.1 milestone Nov 3, 2023
@BreakingPitt BreakingPitt closed this by deleting the head repository Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmudge wmudge wmudge requested changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prompt to local development playbook for https vs. git of cloned projects
2 participants
@BreakingPitt @wmudge